Add Video Decode Testcases for H265 #146
Conversation
There was a problem hiding this comment.
I’m considering making it more modular, with less maintenance and easier integration for upcoming encode and decode tests. We would just need to prepare the .json file, without requiring a separate run.sh for each format. This should make it easier to manage and more lightweight.
Just add Docoder, Encoder.json, and any input clips. The generic runner will automatically detect and execute them.
abbajaj806
force-pushed
the
Video
branch
5 times, most recently
from
c18a16a to
ef23fe7
Compare
|
|
||
| if [ -z "$CFG" ]; then | ||
| log_info "No config argument passed, searching for JSON files in the current working directory (from where the script is executed)." | ||
| find "$test_path" -type f -name "*.json" 2>/dev/null | sort > "$CFG_LIST" |
There was a problem hiding this comment.
The config discovery flow is exiting too early. After the CFG_LIST is repopulated, it immediately skips without rechecking, which means files found in the fallback directory could be missed.
There was a problem hiding this comment.
Resolved in latest commit
There was a problem hiding this comment.
This issue has not been addressed yet.
abbajaj806
force-pushed
the
Video
branch
2 times, most recently
from
d691299 to
ae16c77
Compare
abbajaj806
force-pushed
the
Video
branch
2 times, most recently
from
cf1bfbb to
70e4889
Compare
abbajaj806
force-pushed
the
Video
branch
3 times, most recently
from
bc52a2a to
1f8bb69
Compare
| | `--repeat-policy` | all or any | | ||
| | `--junit FILE` | Output JUnit XML to file | | ||
| | `--dry-run` | Show commands without executing | | ||
|
|
There was a problem hiding this comment.
It would be helpful to include a few more examples showing how a user can launch using these CLI parameters.
| [ "$DMESG_SCAN" -eq 1 ] || return 2 | ||
| MODS='oom|memory|BUG|hung task|soft lockup|hard lockup|rcu|page allocation failure|I/O error' | ||
| EXCL='using dummy regulator|not found|EEXIST|probe deferred' | ||
| if scan_dmesg_errors "$LOG_DIR" "$MODS" "$EXCL"; then |
There was a problem hiding this comment.
Your scan_dmesg_if_enabled() calls scan_dmesg_errors "$LOG_DIR" "$MODS" "$EXCL", but the functiona take (mods, outdir, excl). With the current order, the scan very likely doesn’t work as intended.
There was a problem hiding this comment.
Addressed in latest commit
There was a problem hiding this comment.
This issue has not been addressed yet.
| ############################################################################### | ||
| is_decode_cfg() { | ||
| case "$(basename "$1" | tr '[:upper:]' '[:lower:]')" in | ||
| *dec*.json) return 0 ;; # decode |
There was a problem hiding this comment.
Mode (decode/encode): Your current is_decode_cfg() defaults to decode if it can’t infer from the filename—so it will still treat this as decode (good). But it doesn’t read the "Domain" key yet.
| cfg="$1" | ||
| { | ||
| extract_scalar_key_values "Inputpath" "$cfg" | ||
| extract_scalar_key_values "input" "$cfg" |
There was a problem hiding this comment.
Your helper looks for "Inputpath" (lowercase p), not "InputPath" (uppercase P), so it won’t pick up ./720p_AVC.h264 right now.
There was a problem hiding this comment.
The handling is still missing.
There was a problem hiding this comment.
Addressed in latest commit
There was a problem hiding this comment.
This issue has not been addressed yet.
| cfg="$1" | ||
| { | ||
| extract_scalar_key_values "Inputpath" "$cfg" | ||
| extract_scalar_key_values "input" "$cfg" |
There was a problem hiding this comment.
The handling is still missing.
abbajaj806
force-pushed
the
Video
branch
2 times, most recently
from
1365f40 to
eece946
Compare
| # Generic Video V4L2 runner (encode/decode) for iris_v4l2_test JSON configs. | ||
| # Minimal deps: POSIX sh + grep/sed/awk/find/sort | ||
| # Uses in-tree run_with_timeout() from functestlib.sh when present. | ||
| # SPDX-License-Identifier: BSD-3-Clause-Clear |
There was a problem hiding this comment.
Still copyright is missing.
| [ "$DMESG_SCAN" -eq 1 ] || return 2 | ||
| MODS='oom|memory|BUG|hung task|soft lockup|hard lockup|rcu|page allocation failure|I/O error' | ||
| EXCL='using dummy regulator|not found|EEXIST|probe deferred' | ||
| if scan_dmesg_errors "$LOG_DIR" "$MODS" "$EXCL"; then |
There was a problem hiding this comment.
This issue has not been addressed yet.
| cfg="$1" | ||
| { | ||
| extract_scalar_key_values "Inputpath" "$cfg" | ||
| extract_scalar_key_values "input" "$cfg" |
There was a problem hiding this comment.
This issue has not been addressed yet.
|
|
||
| if [ -z "$CFG" ]; then | ||
| log_info "No config argument passed, searching for JSON files in the current working directory (from where the script is executed)." | ||
| find "$test_path" -type f -name "*.json" 2>/dev/null | sort > "$CFG_LIST" |
There was a problem hiding this comment.
This issue has not been addressed yet.
abbajaj806
force-pushed
the
Video
branch
3 times, most recently
from
6d2ae26 to
3778df2
Compare
abbajaj806
force-pushed
the
Video
branch
2 times, most recently
from
38e0f99 to
fc66087
Compare
…rs and encoders Add Support Video Decode Testcases for H265 Add Support Video Decode Testcases for VP9 Add Support Video Encode Testcases for H265 Signed-off-by: Abhishek Bajaj <[email protected]>
|
We will raise a another request with more modularized Code. |
3 participants
Add Video Decode Testcases for VP9
Add Video Encode Testcases for H265